PP-838 Support for logging via Syslog in PBS


#21

Done

Done

This is done because PBS_SYSLOG value might be between 1 to 7. Therefore I have added this as ‘set’ and not 1

Removed this

Done

Removed this

Done

Done


#22

The maybe change it to “1-7” or “1 to 7” ? it can be set to 0 as well, that’s the only reason I’m bugging you about this.

And I think PBSSyslogUtils is not needed anymore as it only contains internal functions. The functions should be moved to the class where they are used.

Thanks again for being so patient.


#23

Done

Added the existing functions to class PBSLogUtils


#24

Just one last thing Tejas: _get_log_type() should be moved to the class which contains log_match() since log_match() is the function which uses it. So, please move it to the class PBSService


#25

Moved this to class PBSService


#26

Looks good Tejas, thanks for making all the changes