While what happens in the STONITH script is unstable, the interface should be stable. In the same way that hooks are stable, we are creating an interface that allows this script to be called. The name and location of the script well known and are stable as well.
Speaking of hooks, this has the definite feeling of a hook. Is there a reason why this isn’t being added as a secondary_startup hook event type? I thought all the new external callouts were going to be done as hooks.
Interface 1: change the perms to 750. It doesn’t really matter because the perms on server_priv are 750, but it can’t hurt to set them right.
Interface 7: I’d remove this log message. The STONITH script is completely optional for the admin. If they opt out from writing one, why should they have a log message saying the right thing is happening?