Hi Sarita, PFB some comments:
"Tests that insert new vnodes
Tests that alter node resources (like ncpus, memory etc.)"
I don’t know a lot about the restrictions on cpuset moms, so could you please clarify the following:
- Is it just the tests which insert new vnodes? What about the ones which delete vnodes? should they be skipped too?
- should we skip all test cases which alter ANY resource on a node? The ones that you mentioned are consumable resources, is it bad to alter even non-consumables on cpuset nodes?
“A new option added to pbs_benchpress command to increase default test case time out value”: I’m guessing that the original motivation for adding this option was to be able to increase the default test case time out, but one can set this to a really small value as well right? So, I’d change ‘increase’ to just ‘change’ or ‘set’.