Hi @saritakh, thanks for the document. I have few comments:
A. setUpClass() & tearDownClass() method updates:
PTL will now revert PBS under test to the set of configurations that it started on at the end of every test run. This is done by saving the configurations at test suite's setUpClass() method and reverting to the same on test suite's tearDownClass() method.
–> Above is only true if “–use-current-setup” is passed. correct? Also reading the first line it sounded like PTL was not doing it at all. you might want to change that.
–> to make document more readable I will define the new option first and then mention about the updates to setup class/teardownclass and setup. Clearly setup class and setup changes are only applicable when new option is specified. Please mention this explicitly.
–> following doesn’t sound like a good idea to me. For example, what if the configurations are conflicting? I think this is what Ravi is asking above.
pbs_benchpress --use-current-setup User updated PBS - B Defines certain configurations C reverts to PBS - B + C reverts to B
–> load_configuration() will load these saved configurations if altered on the PBS cluster
just for my understanding, if only 2 files are updated then only those will get reverted. correct?
@agrawalravi90 I found the table more clear than the flow diagram. I think we can leave both there as flow diagram is covering the scenario from the table itself.